On 4/2/2012 3:41 PM, Roland Dreier wrote: > On Mon, Apr 2, 2012 at 12:39 PM, Hal Rosenstock <h...@dev.mellanox.co.il> > wrote: >> How about validating the speed in mlx4 before overwriting it ? Would you >> take such a patch ? > > I don't think so... what does speed even mean when we're reporting the > link is down?
It has no meaning but should be a valid not reserved speed. > Do we gain anything from that check? It's a small gain. We preserve the original FW value when possible which means we don't need to remember that this might have be changed by the kernel if some question comes up in the field. Many mlx4 devices/versions do the right thing here and don't return a reserved value. -- Hal > - R. > -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
