On Wed, Jun 26, 2013 at 5:57 AM, Or Gerlitz <ogerl...@mellanox.com> wrote: > Add Infra-structure to support extended uverbs capabilities in a > forward/backward > manner. Uverbs command opcodes which are based on the verbs extensions > approach should > be greater or equal to IB_USER_VERBS_CMD_THRESHOLD. They have new header > format > and processed a bit differently.
I think you missed the feedback I gave to the previous version of this patch: This patch at least doesn't have a sufficient changelog. I don't understand what "extended capabilities" are or why we need to change the header format. What is the "verbs extensions approach"? Why does the kernel need to know about it? What is different about the processing? The only difference I see is that userspace now has a more complicated way to pass the size in, which the kernel seems to nearly ignore -- it just adds the sizes together and proceeds as before. I'm still wondering why the flow steering uverbs commands can't be normal uverbs commands. [And BTW, "infrastructure" is a normal word with no need for capitalization or hyphenation] - R. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
