On Thu, Jun 27, 2013 at 11:55 PM, Hefty, Sean <sean.he...@intel.com> wrote:
> My point was that the IPv6 filter should be defined and used here. The > following basic > filters were defined: > ethernet - src/dst mac ... > ip - src/dst ip > tcp/udp - src/dst port > These are at least somewhat intuitive to me. The IB filter is > ib - (src/dst?) qpn, dgid > This is equivalent to creating a filter that's: > tcpip - port, dst ip > IMO, it would be better to define IB filters using the same structure that > you used for > tcp/ip/ethernet. For example > ibqp - src/dst qpn (pkey?) > ipv6 - src/dst ipv6/gids (flowlabel?) > iblink - src/dst lids, (sl?) > > If the hardware can only support matching on the qpn and dgid, then it can > simply fail > any requests which specify a non-zero mask on the unsupported components. Sean, I agree that the provided filter on dest qpn / dgid doesn't make sense and will fix that out. Still for the initial set of patches that goes in I tend to just remove the IB filter structure and define the different IB filters along your proposal in a follow-up patches/es, OK? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
