On Mon, Apr 08, 2019 at 11:01:04AM +0200, Wolfram Sang wrote:
> On Mon, Apr 08, 2019 at 10:29:28AM +0200, Simon Horman wrote:
> > According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
> > August 24, 2018, the TX clock internal delay mode isn't supported
> > on R-Car E3 (r8a77990) and D3 (r8a77995).
>
> Yes, it made it also into the revised documentation v1.50, see chapter
> 50.2.7., bit 14.
>
> > +static const struct soc_device_attribute ravb_delay_mode_quirk_match[] = {
> > + { .soc_id = "r8a77990", .revision = "ES1.*" },
> > + { .soc_id = "r8a77995", .revision = "ES1.*" },
> > + { /* sentinel */ }
> > +};
>
> I might have missed it but is there a plan to fix this in later
> revisions of D3/E3? I was under the impression that it is not and then
> we could base it on compatible rather than soc_device_match?
I am not aware of any such plan (or the absence of such a plan).
I was unsure weather to go with the compat approach of the quirk approach.
In the end I went with the quirk approach as it seems simpler. But
I'm happy to re-arrange things.
