On 17 Mar 2001 11:55:33 -0500, Johannes Erdfelt wrote:
> > > I'd prefer that selecting one UHCI HCD not be an
> > > arbitrary decision, but that's not my decision to make.
> > >
> > > I also agree with David Johnson that USB device driver
> > > developers should be able to expect consistent behavior
> > > from any/all of the HCDs. It seems to me that we have
> > > discussed this a few times in the past.
> > >
> > > When JE's uhci (alt-JE) HCD has bulk queueing and
> > > PCI alloc consistent support (JE's own, or David's
> > > pci_pool patch), it could easily be the one to choose.
> >
> > Agreed, but I'd like to hear from Johannes whether he agrees
> > that having just one UHCI driver is the way to go and what
> > selection process he intends to use. Johannes?
>
> Since no one has had an opinion in the past, I was going to choose mine.
> I'm sure that's hardly a surprise.
>
> However, I wanted to fix all of the outstanding known bugs first.
> There's little sense in removing usb-uhci since it does work in some
> other situations that my driver does not work in. But once that has been
> fixed, the last reason for keeping two drivers would be gone.
>
> > > The criteria that you (Miles) listed are basically the ones
> > > that I used for several months, along with at least one more,
> > > which could be worded in many ways (examples):
> > >
> > > . which driver uses the kernel API more appropriately
> > > or
> > > . which driver is more "Linux-like"
> > > or
> > > . which driver abuses interrupts less
> >
> > Well, this all sounds good to me.
>
> I don't mind if other people go through this process as well. Anyone?
>
> I've kept those three criteria in mind when I was developing my driver.
Thanks for the reply. Since you are the maintainer, as well,
would you be willing to request a code review of uhci and
usb-uhci? At the very least, you'd get some useful examination
of your code. It would also be possible that there might be
good stuff in the usb-uhci driver that could be migrated into
your code. Of course, it's also possible that the code
reviewers would surprise you and prefer the usb-uhci driver
code base. In which case, we could explore what might be
required to get any usb-uhci bugs fixed before removing uhci
from the tree.
I have suggested Alan Cox and Andrew Morton as possible code
reviewers. Do you think they would be good choices and might
be willing to review the code?
All the best,
Miles
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
