On Wed, Apr 18, 2001 at 06:51:25AM -0500, Ted Milker wrote:
> I've written a driver for the TrackIR device
> (http://www.naturalpoint.com) which isn't a serial device, so I
> had to take the ezusb_write and ezusb_reset functions and put
> them in my driver. I'd much rather see generic part of the
> kernel that these functions are made accessible to devices.
I'd be willing to move the ezusb_* functions into the usb core code, as
it seems that more drivers other than the usb-serial drivers need them.
Does anyone object to this?
> You can download a beta version of my driver at
> http://www.thewretched.org/trackir.html (up soon). I'd
> appreciate any comments on the way I'm doing things and if I'm
> doing anything wrong. This is my first kernel driver I've
> written and I'm new to this.
Comments about the driver. If you do all of the device structure
initialization at probe() time, and hook your device to the *dev passed
to probe(), your driver will be able to handle more than just one device
at a time (currently you do the initialization in the __init function.)
And tiny nit, but you might want to read the kernel coding style :)
But looks very nice, good job. Can this device hook into /dev/mice?
greg k-h
--
greg@(kroah|wirex).com
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
