Re: [linux-usb-devel] [patch] usb-uhci held spinlock

[David Brownell]

> >Note that the FILL_*_URB() macros always re-init the
> >spinlock, so the "reuse this URB" path won't care if the
> >HC didn't drop the lock.
> 
> Does that mean that the FILL_*_URB() macros *must* be called before
> resubmitting?

No, you can always manually init an urb if you do as well as
the FILL_*_URB() macros do.

>From the USB device driver perspective, "resubmit" is no
different from "submit":  they're both "init urb, submit".

>From the HCD perspective, those periodic URBs are never
"unsubmitted" outside of an unlink, so no worries there either.

Though I'd be happier if the urb->lock ownership semantics
were clearer ... only the UHCI controllers use it, and they
don't seem to be consistent about that.





_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel