On Fri, May 18, 2001 at 06:44:07AM -0700, David Brownell wrote:
> What's so bad about freeing inside a callback? When else
> would most drivers have all the facts in hand, so they know
> that they're done using a given URB? Inquiring minds ...
Short answer is "too confusing". I am sure Dan did a due dilligence
looking at code paths and yet he blew it (I would too...).
The fact that the technique is unconventional does not help.
I know where the desire to free inside comes from, we want
to reuse URBs. This is fine, but in that case let's always
free them inside.
I saw how Dan proposes freeing from a BH. That would be
wasteful, I think. What next, a tasklet? We saw that too :)
[I am talking about Mr. Ananian's exercises]
As far as spinlocking goes, I strongly disagree with an idea
to keep a lock across a calback, then perhaps unlock before
we free. A better way would be to have a logics that allows
to unlock before a callback.
-- Pete
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel
