On Mon, Jun 04, 2001 at 03:46:29PM -0400, Pete Zaitcev wrote:
<...> 
> The urb->lock is used intelligently in uhci.c,
> but usb-uhci does not use it at all. Everywhere
> usb-uhci asserts urb->lock, s->urb_list_lock is
> taken already, so urb->lock is totally redundant.
> [Side note: process_urb is exception, but
>   1. it violates lock order by dropping and taking urb_list_lock;

Can you be a bit more specific why you are considering the lock order as a
holy cow? The order is unconventional, but it works and prohibits the
simultaneous completion and unlink, there's IMHO no deadlock possibility. 

-- 
         Georg Acher, [EMAIL PROTECTED]         
         http://www.in.tum.de/~acher/
          "Oh no, not again !" The bowl of petunias          

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to