On Wed, Jun 06, 2001 at 10:22:27PM -0700, xavyer wrote:
> The attached patch is against linux-2.4.6-pre1.
> 
> This changes instances of:
> 
>       info(DRIVER_VERSION " " DRIVER_AUTHOR);
>       info(DRIVER_DESC);
> 
> to:
> 
>       dbg(DRIVER_VERSION ":" DRIVER_DESC);

No, I would argue against this.  I think the modules need to identify
themselves when they are loaded.  Exactly like all of the ethernet
drivers do.  This was something that was talked about at the Linux 2.5
meeting with the ethernet people, and everyone agreed that it made
debugging things in the field easier if the version number was easily
known.  That is why I suggested that xavyer make this patch.

Now I will concede that maybe it should be done once at the first device
seen, but that may be to late in helping to debug things.

Moving this from "info" to "dbg" would not be a good thing.

But I agree that some people don't want to see their names, and that
should be removed if they wish.

Any other thoughts?

thanks,

greg k-h

_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
http://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to