I could, in theory, make a diff -b myself. However, then I would have an extra development tree on my machine to keep track of, and that's something I like to avoid.
Matt
On Tue, May 21, 2002 at 03:22:42AM +0200, [EMAIL PROTECTED] wrote:
> >> It is not clear to me why these CF and SM drivers should
> >> replace sg buffers by a single big contiguous buffer.
>
> > No, they should not be using a single big buffer. They
> > should use the scatter-gather list that was given to them by the midlayer.
>
> Good. I hoped you would say that. That again removes a lot of code.
>
> [Greg, no reason not to apply the previous patch - the next one
> will just remove some more code.]
>
> Matt, you asked for a diff -b. But can't you make that yourself?
> (Apply the patch to some tree, and say diff -r -u -b or so.)
> But if you are short on disk space, I'll send one.
>
> Matt, concerning the s/10/3/ - if that really worries you
> I'll do s/3/10/ again.
>
> [Personally I think that anybody who writes a driver and lets
> it retry ten times is a bad programmer. Retrying is almost always
> the wrong thing to do. In this particular case it also happened
> to crash the kernel. But of course the USB code will improve,
> and some day it will no longer crash the kernel. That day I will
> still think that retrying ten times is a bug.]
>
> Andries
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
Now payink attention, please. This is mouse. Click-click. Easy to
use, da? Now you try...
-- Pitr to Miranda
User Friendly, 10/11/1998
msg06636/pgp00000.pgp
Description: PGP signature
