On Mon, Feb 09, 2004 at 11:50:13AM -0500, James Bottomley wrote: > On Mon, 2004-02-09 at 11:40, Alan Stern wrote: > > In the absence of anything better, we're forced to assume "bad" status > > corresponds to Check Condition... > > > > What do you think, Matt? Should we remove the auto-sense for short > > transfers when we get "good" status? Bearing in mind that it's > > technically legal, but other drivers or programs may not expect it? Also > > bearing in mind that we have no choice but to auto-sense for non-IN > > transfers with the CB transport. > > OK, if you want to understand what the mid-layer problem is, look at > scsi_finish_command(). You see in there we set DRIVER_SENSE if we find > any valid sense code in the sense buffer (including NO SENSE) > > We will return this to the user as a sense error at various points. > > The safest course, if you want to send unsolicited request sense > commands is probably to zero out the sense buffer if you get NO SENSE > back.
This seems like the right approach to me. It should follow the principal
of least suprise for existing users, while work around the reported issue.
Matt
--
Matthew Dharm Home: [EMAIL PROTECTED]
Maintainer, Linux USB Mass Storage Driver
A female who groks UNIX? My universe is collapsing.
-- Mike
User Friendly, 10/11/1998
pgp00000.pgp
Description: PGP signature
