On 9 Feb 2004, James Bottomley wrote:

> OK, if you want to understand what the mid-layer problem is, look at
> scsi_finish_command().  You see in there we set DRIVER_SENSE if we find
> any valid sense code in the sense buffer (including NO SENSE)
> 
> We will return this to the user as a sense error at various points.

I don't understand the reasoning here.  If DRIVER_SENSE is set it must 
mean the driver had some reason of its own for wanting to get the sense 
data -- presumably to find out whether or not some error occurred.  So why 
should this get passed to the user as a sense error?  Especially if the 
sense code is NO SENSE.  Logically that should indicate the driver needed 
to find out whether or not there was error, and it learned that there 
wasn't.

> The safest course, if you want to send unsolicited request sense
> commands is probably to zero out the sense buffer if you get NO SENSE
> back.

Okay, we can do that.

Alan Stern




-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to