Hi,
open() is (for char devices) still called under BKL, so this is
just uselessly eating cycles. And, more importantly, locking
is not thought through. It is correct by accident currently.
Regards
Oliver
You can import this changeset into BK by piping this whole message to:
'| bk receive [path to repository]' or apply the patch as usual.
===================================================================
[EMAIL PROTECTED], 2004-03-19 16:01:14+01:00, [EMAIL PROTECTED]
- remove useless BKL
usblp.c | 5 +----
1 files changed, 1 insertion(+), 4 deletions(-)
diff -Nru a/drivers/usb/class/usblp.c b/drivers/usb/class/usblp.c
--- a/drivers/usb/class/usblp.c Fri Mar 19 16:11:18 2004
+++ b/drivers/usb/class/usblp.c Fri Mar 19 16:11:18 2004
@@ -330,8 +330,6 @@
if (minor < 0)
return -ENODEV;
- lock_kernel();
-
retval = -ENODEV;
intf = usb_find_interface(&usblp_driver, minor);
if (!intf) {
@@ -359,7 +357,7 @@
retval = 0;
#endif
- usblp->used = 1;
+ usblp->used = 1; /*hence we may block*/
file->private_data = usblp;
usblp->writeurb->transfer_buffer_length = 0;
@@ -376,7 +374,6 @@
}
}
out:
- unlock_kernel();
return retval;
}
===================================================================
This BitKeeper patch contains the following changesets:
1.1182
## Wrapped with gzip_uu ##
begin 664 bkpatch4778
M'XL(`)8-6T```[64VVK;0!"&K[U/,9"[!$LSJY.EHN`F*6U)H,9MKDHOUM+$
M,M:INU)"0`_?C5R2IM1UCUHA+3L[/_//?NP17!O6R:0I-[>LQ1&\:4R73.R\
MZG.NG9K[;5\YC5[;V+)I;,PMFHK=78+[03,;M]S4O9E*)Q!VUT)U60$V:)()
M.=[C2G??<C)9OGI]??5R*42:PGFAZC6_YP[25'2-OE5E;N:J*\JF=CJM:E-Q
MIYRLJ8;'K8-$E'8$%'D8A`.%Z$=#1CF1\HESE/XL],6NO/D/?#R7\M&C&".<
M$0U>1#(0%T`.T4P"^BYZ+L5`88*4D']BOXBP7QI."*8HSN#?>CD7&4Q!<]7<
M,O2&2S8&SBZOQ"5X$<I0+)XZ*::_^0B!"[EMAIL PROTECTED])S_>#9N+U9N:W>U!UK)_NF
M?!\I&OP9DAR"B-1-O%JIV(]"CG_6KV>R6:G,."O;[EMAIL PROTECTED]@$%,?AR,S>
ME,,,_84)T59*?^[9S->Z;YMVPP^*']>:UY\.NT`I`T0:`AG/Y`A8&'^/%X:_
MAI?_G_&J:^:<\Z]\[?K^#J;Z;GPM+XO]1_`'\%UXG@>V)UXH@<3;W6\RZDU/
M+>LYI$`OP#TNN,[EMAIL PROTECTED]:[EMAIL PROTECTED]@LA
'GK^1X`0`````
`
end
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
