Am Friday 19 March 2004 18:53 schrieb Pete Zaitcev:
> On Fri, 19 Mar 2004 16:14:56 +0100
> Oliver Neukum <[EMAIL PROTECTED]> wrote:
>
> > open() is (for char devices) still called under BKL, so this is
> > just uselessly eating cycles. And, more importantly, locking
> > is not thought through. It is correct by accident currently.
>
> I wouldn't touch it before a replacement is done. I vote for
> making the usblp->sem static and using that instead.
>
> What do you think about the attached patch?
Much, much better :-)
Except that you forgot to initialise the semaphore.
Regards
Oliver
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
