Am Friday 19 March 2004 20:52 schrieb Pete Zaitcev:
> On Fri, 19 Mar 2004 19:10:35 +0100
> Oliver Neukum <[EMAIL PROTECTED]> wrote:
> 
> > > What do you think about the attached patch?
> > 
> > Much, much better :-)
> > Except that you forgot to initialise the semaphore.
> 
> You are right. I suppose just replacing it with DECLARE_MUTEX ought
> to do the trick.
> 
> I take it you understood at once why neither release nor open take
> usblp->sem, but disconnect takes both. I am thinking
> perhaps a comment is in order, but I cannot formulate a good one.

Perhaps a descriptive name for the semaphore would solve the task.
Like usblp_existance_sem ?

        Regards
                Oliver


-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to