On Thu, 25 Mar 2004, Colin Leroy wrote: > Additionally, there's still a reference to altsetting[0] in cdc-acm.c (in > acm_ctrl_msg()), I don't know if it's intentional or should have been > converted from > acm->control->altsetting[0].desc.bInterfaceNumber > to > acm->control->cur_altsetting.desc.bInterfaceNumber > ?
It's not as bad as it looks. All the altsetting entries for an interface are guaranteed to have the same value stored in desc.bInterfaceNumber, so it really doesn't matter whether that value is retrieved from the first entry in the altsetting array or the current entry -- provided of course that cur_altsetting is a valid pointer! It's mostly just a matter of taste. I generally prefer to use cur_altsetting because that's the one currently installed in the device. Alan Stern ------------------------------------------------------- This SF.Net email is sponsored by: IBM Linux Tutorials Free Linux tutorial presented by Daniel Robbins, President and CEO of GenToo technologies. Learn everything from fundamentals to system administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click _______________________________________________ [EMAIL PROTECTED] To unsubscribe, use the last form field at: https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
