On Thu, 25 Mar 2004, Colin Leroy wrote:

> Hi, 
> 
> Found out !
> cdc-acm wants both interfaces to be ready (cur_altsetting initialized) when 
> acm_probe() is called. Hence, we have to make two parts out of the loop in 
> message.c::usb_set_configuration(): one to init things, one to register them. 
> 
> The attached patch does that. It fixes the oops, and doesn't break any of my USB 
> peripheral (printer, scanner, mouse, and diskonkey).
> 
> I hope it's fine enough to go in :)

It's obvious once you see the problem, isn't it?

Duncan Sands found exactly the same problem and the same solution a few 
months ago, but it was never added in.

In this case, your patch could be improved by calling device_initialize()  
during the first loop and device_add() during the second.  However, that
region of code is kind of in flux right at the moment.  When things settle
down, I promise to remember your change and make sure it gets in.

Alan Stern



-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
[EMAIL PROTECTED]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel

Reply via email to