On Fri, 28 Jul 2006 10:25:32 -0300, "Thiago Galesi" <[EMAIL PROTECTED]> wrote:
> Fixes several lines that overrun 80 columns in Prolific pl2303 driver
> - usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count,
> port->write_urb->transfer_buffer);
> + usb_serial_debug_data(debug, &port->dev, __FUNCTION__, count
> + , port->write_urb->transfer_buffer);
Are you out of your mind?
> -static void pl2303_set_termios (struct usb_serial_port *port, struct
> termios *old_termios)
> +static void pl2303_set_termios (struct usb_serial_port *port, struct termios
> + *old_termios)
> {
Ditto.
> @@ -370,7 +373,8 @@ static void pl2303_set_termios (struct u
> spin_lock_irqsave(&priv->lock, flags);
> if (!priv->termios_initialized) {
> *(port->tty->termios) = tty_std_termios;
> - port->tty->termios->c_cflag = B9600 | CS8 | CREAD | HUPCL |
> CLOCAL;
> + port->tty->termios->c_cflag = B9600 | CS8 | CREAD
> + | HUPCL | CLOCAL;
This is more or less acceptable.
> @@ -378,8 +382,10 @@ static void pl2303_set_termios (struct u
> cflag = port->tty->termios->c_cflag;
> /* check that they really want us to change something */
> if (old_termios) {
> +
> if ((cflag == old_termios->c_cflag) &&
> - (RELEVANT_IFLAG(port->tty->termios->c_iflag) ==
> RELEVANT_IFLAG(old_termios->c_iflag))) {
> + (RELEVANT_IFLAG(port->tty->termios->c_iflag) ==
> + RELEVANT_IFLAG(old_termios->c_iflag))) {
NO. And what's up with this extra empty line?
> - dev_err(&port->dev, "pl2303 driver does not support the
> baudrate
> requested (fix it)\n");
> + dev_err(&port->dev, "pl2303 driver does not support"
> + "the baudrate requested (fix it)\n");
> break;
This segment looks ok.
Overall, this looks like a shining example why this sorts of cleanups
should not be done.
-- Pete
-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys -- and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
[email protected]
To unsubscribe, use the last form field at:
https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
