Hi Jason,

Jason Sharpee wrote:
> 
> > 2.  Petko:  pegasus patch (attached):
> >
> >     Here is patch against pre-8, which should
> >     fix tx timeout problems reported this
> >     weekend in the list. Also interrupt pipe
> >     is now activated.
> 
> I noticed the unlink code to fix the problem was added by the TX
> timeout in write_bulk;  is this a better place for this?  I had added the
> unlink in the start_xmit function as JE had mentioned.


usb_unlink_urb() is just on the right place. JE made very valuable
suggestion, but he wrote wrong function name (e.g. pegasus_start_xmit).
If you look again at his patch

> > > > I bet you it needs something like this line in pegasus_start_xmit:
> > > >
> > > >             warn("%s: Tx timed out. Reseting...", net->name);
> > > > +           usb_unlink_urb(&pegasus->tx_urb);

and then look at pegasus code you'll see that we're talking about
pegasus_tx_timeout()
Also i am curious where you place usb_unlink_urb() in
pegasus_start_xmit()
 
> Also, I tried out the modified pegasus driver with my ohci system and got
> 710Kbytes/sec on a FTP of 720megs with no errors. :)


That's great. My best result is 600KB/sec with 650MB file.
Can someone report any values(comments) guys?


best,
Petkan

---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]

Reply via email to