On Tue, 23 May 2000, Petko Manolov wrote:
> Jason Sharpee wrote:
> >
> > I put the the unlink here in when there is a problem with submitting a
> > urb, in pegasus_start_xmit.
> >
> > *** 303,308 **** --- 303,309 ----
> > if ((res = usb_submit_urb(&pegasus->tx_urb))) {
> > warn("failed tx_urb %d", res);
> > pegasus->stats.tx_errors++;
> > + usb_unlink_urb(&pegasus->tx_urb);
> > netif_start_queue(net);
> > } else {
> > pegasus->stats.tx_packets++;
>
>
> Hm, if usb_submit_urb() returns !0 then URB is not submitted
> so there is no point of unlinking. You actually have to
> unlink tx_urb only in the case there is tx timeout.
Thanks for the explanation. I was thinking that it still submitted the
urb and was stuck in the queue. I wonder why this solved the problem for
me though, interesting.
> > Im still trying to see what causes the Timeout to occur in the first
> > place.
>
>
> I can't get such messages at least on my PC (ohci HC) with
> last patch. Almost 3GB net traffic since last boot.
My ohci system has been routing for the last 24hour without problem now.
My uhci systems are having the timeout messages. Ill try and take a
closer look at this problem tonight and provide some detailed info.
-Jason
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
