On Tue, 23 May 2000, Petko Manolov wrote:
> Hi Jason,
>
> Jason Sharpee wrote:
> >
> > > 2. Petko: pegasus patch (attached):
> > >
> > > Here is patch against pre-8, which should
> > > fix tx timeout problems reported this
> > > weekend in the list. Also interrupt pipe
> > > is now activated.
> >
> > I noticed the unlink code to fix the problem was added by the TX
> > timeout in write_bulk; is this a better place for this? I had added the
> > unlink in the start_xmit function as JE had mentioned.
>
>
> usb_unlink_urb() is just on the right place. JE made very valuable
> suggestion, but he wrote wrong function name (e.g. pegasus_start_xmit).
> If you look again at his patch
>
> > > > > I bet you it needs something like this line in pegasus_start_xmit:
> > > > >
> > > > > warn("%s: Tx timed out. Reseting...", net->name);
> > > > > + usb_unlink_urb(&pegasus->tx_urb);
>
> and then look at pegasus code you'll see that we're talking about
> pegasus_tx_timeout()
> Also i am curious where you place usb_unlink_urb() in
> pegasus_start_xmit()
>
I put the the unlink here in when there is a problem with submitting a
urb, in pegasus_start_xmit.
*** 303,308 **** --- 303,309 ----
if ((res = usb_submit_urb(&pegasus->tx_urb))) {
warn("failed tx_urb %d", res);
pegasus->stats.tx_errors++;
+ usb_unlink_urb(&pegasus->tx_urb);
netif_start_queue(net);
} else {
pegasus->stats.tx_packets++;
Im still trying to see what causes the Timeout to occur in the first
place.
> > Also, I tried out the modified pegasus driver with my ohci system and got
> > 710Kbytes/sec on a FTP of 720megs with no errors. :)
>
>
> That's great. My best result is 600KB/sec with 650MB file.
> Can someone report any values(comments) guys?
I get ohci - 710KB/s, usb-uhci - 370KB/s, uhci - 310KB/s, on switched
100BT. I can definitely tell how much the hardware assistance helps with
the ohci chipset (You get what you pay for ;) ). If I run linux with
multi-user mode, both uchi drivers performance varies on what else is
running on the system by quite a bit and the timeout's probably dont help
the performance either.
I wonder if the EHCI spec will do even better.
Thanks for your time, guys!
-Jason
---------------------------------------------------------------------
To unsubscribe, e-mail: [EMAIL PROTECTED]
For additional commands, e-mail: [EMAIL PROTECTED]
