On Tue, Jan 28, 2014 at 6:19 PM, Phoebe Buckheister <phoebe.buckheis...@itwm.fraunhofer.de> wrote: > On Mon, 27 Jan 2014 22:31:03 +0400 > Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: >> > + nla_put_u8(msg, IEEE802154_ATTR_LBT_ENABLED, phy->lbt)) >> >> nla_get/put_flag please. > > I had actually avoided this to allow set_phyparams without doing a phy > dump first. Flags are purely there/missing, which encodes the value. > phy_setparams though can change a number of things, so i can either > always change all parameters of the phy (which will lead to surprises > when further flags are added down the road), or add one command for > each parameter. I would rather keep the bool payload in the attribute > so that we can add further phy parameters later without disturbing > users that don't copy all flags from a preceding dump.
Hmm. nla_get/put_flag act on boolean attributes. See (for example) net/wireless/nl80211.c -- With best wishes Dmitry ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
