On Mon, 27 Jan 2014 22:21:26 +0400 Dmitry Eremin-Solenikov <dbarysh...@gmail.com> wrote: > s/er/or/ > > Isn't the pib_lock required for it?
Yes, I've neglected locking entirely. The next version of the set will include proper locking requirements and locking where it's needed for correctness (I hope). > > + txpower_wpan = ((unsigned char) (txpower << 2)) >> 2; > > Why are the shifts necessary? I've actually just copied that piece from the display code that takes the phy->transmit_power and converts it to textual form. I'm currently not aware of a short way to do this that doesn't rely on implementation-defined conversions, the correct way would be memcpy to unsigned int and bitwise and with 0x3F. > > + rc = phy->set_txpower(phy, txpower); > > Hmm? I thought we pass signed value to phy, but you have just > converted it to unsigned. txpower is still unsiged, txpower_wpan is the encoded value for the phy pib. ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
