On Tue, Jan 28, 2014 at 9:49 PM, Alexander Aring <alex.ar...@gmail.com> wrote: > On Mon, Jan 27, 2014 at 10:31:03PM +0400, Dmitry Eremin-Solenikov wrote: >> On 27/01/14 20:03, Phoebe Buckheister wrote: >> > Listen-before-talk is an alternative to CSMA in uncoordinated networks >> > and prescribed by european regulations if one wants to have a device >> > with radio duty cycles above 10% (or less in some bands). Add a phy >> > property to enable/disable LBT in the phy, including support in the >> > at86rf230 driver for RF212 chips. >> > >> > Signed-off-by: Phoebe Buckheister <phoebe.buckheis...@itwm.fraunhofer.de> >> > --- >> >> > +static int >> > +at86rf230_set_lbt(struct ieee802154_dev *dev, u8 on) >> >> Judging from datasheets I have, this is rf212-specific. Please name it >> so. And the argument is bool, isn't it? > > should we not do here a if (!isrf212(foo)) return -ENOTSUPP; if this is > at86rf212 specific?
It if will go to at86rf212-only _ops, it can live w/o a check -- With best wishes Dmitry ------------------------------------------------------------------------------ WatchGuard Dimension instantly turns raw network data into actionable security intelligence. It gives you real-time visual feedback on key security issues and trends. Skip the complicated setup - simply import a virtual appliance and go from zero to informed in seconds. http://pubads.g.doubleclick.net/gampad/clk?id=123612991&iu=/4140/ostg.clktrk _______________________________________________ Linux-zigbee-devel mailing list Linux-zigbee-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
