Hello.
On 02/12/2014 07:37 PM, Phoebe Buckheister wrote:
> The standard assigns channel 0 on page 2 to be 100kbps QPSK in the
> 868.3MHz band. Add support to the at86rf230 driver for this channel and
> page, at the moment predicated only for the RF212 chip.
> Per the datasheet, configurations for page 0, channels 0 to 10 and page
> 2, channels 0 to 10 differ only in the BPSK_QPSK bit. Support for
> channels 1 to 10 is untested.
> Signed-off-by: Phoebe Buckheister <phoebe.buckheis...@itwm.fraunhofer.de>
> ---
> drivers/net/ieee802154/at86rf230.c | 17 ++++++++++++++---
> 1 file changed, 14 insertions(+), 3 deletions(-)
> diff --git a/drivers/net/ieee802154/at86rf230.c
> b/drivers/net/ieee802154/at86rf230.c
> index 99bc822..f6338c4 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
[...]
> @@ -595,6 +596,14 @@ at86rf212_set_channel(struct at86rf230_local *lp, int
> page, int channel)
> if (rc < 0)
> return rc;
>
> + if (page == 0)
> + rc = at86rf230_write_subreg(lp, SR_BPSK_QPSK, 0);
> + else
> + rc = at86rf230_write_subreg(lp, SR_BPSK_QPSK, 1);
> +
Don't think empty line is needed here.
> + if (rc < 0)
> + return rc;
> +
> return at86rf230_write_subreg(lp, SR_CHANNEL, channel);
> }
>
[...]
> @@ -1067,9 +1077,10 @@ static int at86rf230_probe(struct spi_device *spi)
>
> spi_set_drvdata(spi, lp);
>
> - if (is_rf212(lp))
> + if (is_rf212(lp)) {
> dev->phy->channels_supported[0] = 0x00007FF;
> - else
> + dev->phy->channels_supported[2] = 0x00007FF;
> + } else
> dev->phy->channels_supported[0] = 0x7FFF800;
Have to use {} in both arms of the *if* statement now -- see
Documentation/CodingStyle.
WBR, Sergei
------------------------------------------------------------------------------
Android apps run on BlackBerry 10
Introducing the new BlackBerry 10.2.1 Runtime for Android apps.
Now with support for Jelly Bean, Bluetooth, Mapview and more.
Get your Android app in front of a whole new audience. Start now.
http://pubads.g.doubleclick.net/gampad/clk?id=124407151&iu=/4140/ostg.clktrk
_______________________________________________
Linux-zigbee-devel mailing list
Linux-zigbee-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linux-zigbee-devel
