On Monday, September 12, 2016 2:47:37 PM CEST Michael Ellerman wrote:
> >> @@ -1058,7 +1058,7 @@ static int mpc85xx_mc_err_probe(struct
> >> platform_device *op)
> >>
> >> pdata = mci->pvt_info;
> >> pdata->name = "mpc85xx_mc_err";
> >> - pdata->irq = NO_IRQ;
> >> + pdata->irq = 0;
> >> mci->pdev = &op->dev;
> >> pdata->edac_idx = edac_mc_idx++;
> >> dev_set_drvdata(mci->pdev, mci);
> >
> > That part went into drivers/edac/fsl_ddr_edac.c which is only the
> > freescale memory controller being shared between ARM and PPC, see
> >
> > http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
> >
> > But that shouldn't change the issue wrt ->irq as now it is implicitly 0.
>
> Ah OK.
>
> NO_IRQ is -1 on ARM (or at least it can be?), see arch/arm/include/asm/irq.h.
>
> So I'll leave that one alone for now.
I don't think there is any way to build the mpc85xx on ARM, it depends
on the powerpc-specific "FSL_SOC" symbol and it uses the in_be32/out_be32
MMIO helpers that are not defined on ARM.
I've sent patches to remove all uses of NO_IRQ that happen on ARM.
Please remove this instance too.
Arnd
