On Tue, Jan 08, 2008 at 09:01:30AM -0700, John Rigby wrote:
> +     [EMAIL PROTECTED] {
> +             device_type = "board-control";
> +             reg = <82000000 8000>;
> +     };

Should be:

[EMAIL PROTECTED] {
        compatible = "fsl,mpc5121ads-cpld";
        reg = <82000000 8000>;
};

> +             ref-frequency = <3ef1480>;      // 66MHz ref
> +             bus-frequency = <5e69ec0>;      // 99MHz ips ref

Please specify these in decimal rather than hex (using the d# prefix, or
better yet /dts-v1/).

> +             // IPIC
> +             // interrupts cell = <intr #, sense>
> +             // sense values match linux IORESOURCE_IRQ_* defines:
> +             // sense == 8: Level, low assertion
> +             // sense == 2: Edge, high-to-low change
> +             //
> +             ipic: [EMAIL PROTECTED] {
> +                     interrupt-controller;
> +                     #address-cells = <0>;
> +                     #interrupt-cells = <2>;
> +                     reg = <c00 100>;
> +                     built-in;
> +                     device_type = "ipic";
> +             };

Remove built-in.

-Scott
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev

Reply via email to