On Tue, 8 Jan 2008 09:01:33 -0700 John Rigby <[EMAIL PROTECTED]> wrote: > > +++ b/drivers/serial/mpc512x_uart.c > > +#include <asm/of_platform.h>
Purely to avoid suggestions of favouritism, I will not the above. :-)
> +static struct of_device_id mpc512x_uart_of_match[] = {
Please make this const.
> +static void mpc512x_uart_of_enumerate(void)
> +{
> + for_each_node_by_type(np, "serial") {
> + if (!of_match_node(mpc512x_uart_of_match, np))
> + continue;
> +
> + /* Is a particular device number requested? */
> + devno = of_get_property(np, "port-number", NULL);
> + mpc512x_uart_of_assign(of_node_get(np), devno ? *devno : -1);
This of_node_get() should be in mpc512x_uart_of_assign() where the
reference is kept.
> +static struct of_platform_driver mpc512x_uart_of_driver = {
> + .owner = THIS_MODULE,
> + .name = "mpc52xx-psc-uart",
You don't need these two (we are removing them) but move the .owner
assignment to the .driver part below.
> + .match_table = mpc512x_uart_of_match,
> + .probe = mpc512x_uart_of_probe,
> + .remove = mpc512x_uart_of_remove,
> +#ifdef CONFIG_PM
> + .suspend = mpc512x_uart_of_suspend,
> + .resume = mpc512x_uart_of_resume,
> +#endif
> + .driver = {
> + .name = "mpc52xx-psc-uart",
> + },
> +};
--
Cheers,
Stephen Rothwell [EMAIL PROTECTED]
http://www.canb.auug.org.au/~sfr/
pgpIDRyx6Wcjf.pgp
Description: PGP signature
_______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev
