Re: [PATCH] cxl: Unlock on error in probe

[Frederic Barrat]

Le 05/05/2017 à 07:34, Dan Carpenter a écrit :

We should unlock if get_cxl_adapter() fails.

Fixes: 594ff7d067ca ("cxl: Support to flash a new image on the adapter from a 
guest")
Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>

Acked-by: Frederic Barrat <fbar...@linux.vnet.ibm.com>

Thanks!

  Fred

diff --git a/drivers/misc/cxl/flash.c b/drivers/misc/cxl/flash.c
index 7c61c70ba3f6..37475abea3e6 100644
--- a/drivers/misc/cxl/flash.c
+++ b/drivers/misc/cxl/flash.c
@@ -401,8 +401,10 @@ static int device_open(struct inode *inode, struct file 
*file)
        if (down_interruptible(&sem) != 0)
                return -EPERM;

-       if (!(adapter = get_cxl_adapter(adapter_num)))
-               return -ENODEV;
+       if (!(adapter = get_cxl_adapter(adapter_num))) {
+               rc = -ENODEV;
+               goto err_unlock;
+       }

        file->private_data = adapter;
        continue_token = 0;
@@ -446,6 +448,8 @@ static int device_open(struct inode *inode, struct file 
*file)
                free_page((unsigned long) le);
 err:
        put_device(&adapter->dev);
+err_unlock:
+       up(&sem);

        return rc;
 }