On 04/09/19 5:50 PM, Michael Ellerman wrote: > Hari Bathini <hbath...@linux.ibm.com> writes: > [...] >> +/* >> + * CPU state data is provided by f/w. Below are the definitions >> + * provided in HDAT spec. Refer to latest HDAT specification for >> + * any update to this format. >> + */ > > How is this meant to work? If HDAT ever changes the format they will > break all existing kernels in the field. > >> +#define HDAT_FADUMP_CPU_DATA_VERSION 1 Changes are not expected here. But this is just to cover for such scenario, if that ever happens. Also, I think it is a bit far-fetched to error out if versions mismatch. Warning and proceeding sounds worthier because the changes are usually backward compatible, if and when there are any. Will update accordingly... - Hari
- Re: [PATCH v5 17/31] powernv/fadump: Warn before pr... Michael Ellerman
- [PATCH v5 18/31] powernv/fadump: handle invalidation of ... Hari Bathini
- [PATCH v5 19/31] powerpc/fadump: Update documentation ab... Hari Bathini
- Re: [PATCH v5 19/31] powerpc/fadump: Update documen... Michael Ellerman
- Re: [PATCH v5 19/31] powerpc/fadump: Update doc... Oliver O'Halloran
- Re: [PATCH v5 19/31] powerpc/fadump: Update... Michael Ellerman
- [PATCH v5 20/31] powerpc/fadump: use smaller offset whil... Hari Bathini
- Re: [PATCH v5 20/31] powerpc/fadump: use smaller of... Michael Ellerman
- [PATCH v5 21/31] powernv/fadump: process architected reg... Hari Bathini
- Re: [PATCH v5 21/31] powernv/fadump: process archit... Michael Ellerman
- Re: [PATCH v5 21/31] powernv/fadump: process ar... Hari Bathini
- Re: [PATCH v5 21/31] powernv/fadump: proces... Oliver O'Halloran
- Re: [PATCH v5 21/31] powernv/fadump: pr... Hari Bathini
- Re: [PATCH v5 21/31] powernv/fadum... Michael Ellerman
- Re: [PATCH v5 21/31] powernv/f... Hari Bathini
- [PATCH v5 22/31] powerpc/fadump: make crash memory range... Hari Bathini
- [PATCH v5 23/31] powerpc/fadump: consider reserved range... Hari Bathini
- [PATCH v5 24/31] powerpc/fadump: improve how crashed ker... Hari Bathini
- [PATCH v5 26/31] powerpc/fadump: update documentation ab... Hari Bathini
- [PATCH v5 27/31] powernv/opalcore: export /sys/firmware/... Hari Bathini
- [PATCH v5 25/31] powernv/fadump: add support to preserve... Hari Bathini