On Thu, Oct 23, 2025 at 09:59:41PM +0200, Diederik de Haas wrote: > Hi Bjorn, > > Thanks for the patch :-) > > On Thu Oct 23, 2025 at 8:25 PM CEST, Bjorn Helgaas wrote: > > On Thu, Oct 23, 2025 at 01:06:26PM -0500, Bjorn Helgaas wrote: > >> From: Bjorn Helgaas <[email protected]> > >> > >> f3ac2ff14834 ("PCI/ASPM: Enable all ClockPM and ASPM states for devicetree > >> platforms") enabled Clock Power Management and L1 PM Substates, but those > >> features depend on CLKREQ# and possibly other device-specific > >> configuration. We don't know whether CLKREQ# is supported, so we shouldn't > >> blindly enable Clock PM and L1 PM Substates. > >> > >> Enable only ASPM L0s and L1, and only when both ends of the link advertise > >> support for them. > >> > >> Fixes: f3ac2ff14834 ("PCI/ASPM: Enable all ClockPM and ASPM states for > >> devicetree platforms") > >> Reported-by: Christian Zigotzky <[email protected]> > >> Link: > >> https://lore.kernel.org/r/[email protected]/ > >> Reported-by: FUKAUMI Naoki <[email protected]> > >> Closes: > >> https://lore.kernel.org/r/[email protected]/ > >> Reported-by: Herve Codina <[email protected]> > >> Link: https://lore.kernel.org/r/[email protected]/ > >> Reported-by: Diederik de Haas <[email protected]> > >> Link: https://lore.kernel.org/r/[email protected]/ > >> Signed-off-by: Bjorn Helgaas <[email protected]> > >> Tested-by: FUKAUMI Naoki <[email protected]> > > > > Provisionally applied to pci/for-linus, hoping to make v6.18-rc3. > > > > Happy to add any testing reports or amend as needed. > > My build with your patch (on top of 6.18-rc2) just finished, so I > installed it and rebooted into it. > Happy to report that everything seems to be working fine and I can't > find any errors, warnings or other messages with 'nvme' in dmesg that > indicate sth could be wrong. IOW: it does indeed fix the issue I > reported earlier. So feel free to add my: > > Tested-by: Diederik de Haas <[email protected]>
That's tremendous, thank you for all your help and testing! I know it's frustrating and time consuming when things break, and I really appreciate your reports and help. Bjorn
