Re: [PATCH v2 03/23] powerpc/pseries/cmm: remove cmm_balloon_compaction_init()

[David Hildenbrand (Red Hat)]

@@ -573,11 +567,12 @@ static int cmm_init(void)
                return -EOPNOTSUPP;

        balloon_devinfo_init(&b_dev_info);
-       cmm_balloon_compaction_init();
+       if (IS_ENABLED(CONFIG_BALLOON_COMPACTION))
+               b_dev_info.migratepage = cmm_migratepage;

        rc = register_oom_notifier(&cmm_oom_nb);
        if (rc < 0)
-               goto out_balloon_compaction;
+               return rc;

        if ((rc = register_reboot_notifier(&cmm_reboot_nb)))
                goto out_oom_notifier;
@@ -606,7 +601,6 @@ static int cmm_init(void)
        unregister_reboot_notifier(&cmm_reboot_nb);
  out_oom_notifier:
        unregister_oom_notifier(&cmm_oom_nb);
-out_balloon_compaction:

So silly, I assume before there was more that happened here?

Right, I commented that above in the patch description.

Thanks!

--
Cheers

David