On Tuesday 04 November 2008 07:16, Benjamin Herrenschmidt wrote:
> > It is device_type for PCIe right now, I'm afraid. This was what we agreed
> > upon. Here a code sniplet from the patch:
> >
> > /* Check if device_type property is set to "pci" or "pci-endpoint".
> > * Resulting from this setup this PCIe port will be configured
> > * as root-complex or as endpoint.
> > */
> > val = of_get_property(port->node, "device_type", NULL);
> > if (!strcmp(val, "pci-endpoint")) {
> > port->endpoint = 1;
> > } else if (!strcmp(val, "pci")) {
> > port->endpoint = 0;
> > } else {
> > printk(KERN_ERR "PCIE: missing or incorrect device_type for
> > %s\n",
> > np->full_name);
> > return;
> > }
>
> Allright, that was a bad idea from both of us, David will have my
> skin ...
>
> We should try to move toward something like an "endpoint" property and a
> "pci-endpoint" name instead.
I must admit that I am not sure what you mean by (pci-endpoint) _name_.
Do you mean something like this:
PCI: [EMAIL PROTECTED] {
endpoint = "pci-endpoint";
...
To many "endpoint" appearances for my taste:-)
Matthias
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org/mailman/listinfo/linuxppc-dev
