On Thu, Nov 19, 2009 at 10:42 AM, Stephen Neuendorffer <stephen.neuendorf...@xilinx.com> wrote: > > >> -----Original Message----- >> From: linuxppc-dev-bounces+stephen=neuendorffer.n...@lists.ozlabs.org > [mailto:linuxppc-dev- >> bounces+stephen=neuendorffer.n...@lists.ozlabs.org] On Behalf Of Arnd > Bergmann >> Sent: Thursday, November 19, 2009 9:33 AM >> To: Stephen Neuendorffer >> Cc: John Linn; Alon Ziv; linuxppc-dev@lists.ozlabs.org >> Subject: Re: Bug in drivers/serial/of_serial.c? >> >> On Thursday 19 November 2009, Stephen Neuendorffer wrote: >> > If the problem is in the device trees that are being generated, we >> > should fix the issue there. >> > We've been trying to avoid putting the fully specified IP versions > in >> > the kernel like this, since >> > the IP changes so often. >> >> No, the problem that Alon has is that the firmware currently has no >> way whatsoever to give a correct device tree, because of-serial.c >> does not even know about ns16550a. >> >> The patch adds both a special-case for the specific uart he >> is using so that one is grandfathered in and a new compatible >> value so future boards can specify both ns16550a and ns16550. > > That's true... The 16550a line still needs to get added, but not the > xlnx- > specific line.
The xlnx- line should be added and is entirely appropriate for exactly the reason Arnd stated. g. -- Grant Likely, B.Sc., P.Eng. Secret Lab Technologies Ltd. _______________________________________________ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev