On 06/10/2015 11:03 AM, Daniel Axtens wrote:
>
>> +static int instr_is_branch_xlform(unsigned int instr)
>> +{
>> + return branch_opcode(instr) == 19;
>> +}
> Why do these not return bool? The functions below do.
Yeah they can, will change it.
>> +
>> +bool instr_is_indirect_func_call(unsigned int instr)
>> +{
>> + /* XL-form instruction with LR set */
>> + if (instr_is_branch_xlform(instr) && is_branch_link_set(instr))
>> + return true;
>> +
>> + return false;
>> +}
> Both of these functions could be made into a single 'return' statement,
> right?
Yeah, right.
_______________________________________________
Linuxppc-dev mailing list
Linuxppc-dev@lists.ozlabs.org
https://lists.ozlabs.org/listinfo/linuxppc-dev
