Hi Enrico, On Wed, Dec 09, 2009 at 03:05:36PM +0100, Enrico Ros wrote: > Hello, I just opened a git clone of xf86-input-wacom on Gitorious at: > http://gitorious.org/linuxwacom/xf86-input-wacom > > In this repository I'll try to merge the changes that some people at Ubuntu > Forums did to support newer devices, like the Bamboo Fun. Unfortunately their > patches are 'snapshots based' and don't apply nor work on current xf86-input- > wacom. > > I've just pushed my first commit that fixes a possible crash if kernel module > is 'newer' than the driver. You can find it on: > http://gitorious.org/linuxwacom/xf86-input-wacom/commits/for-whot > > It's git, so a pull is the easiest way to integrate changes upstream.
Thanks for the patches and you're right, pull is the easiest way. Two comments regarding the patches though: - using ErrorF is generally discouraged in the driver. While it's a public symbol exported by the server, it sidesteps some grep-able prefixes and the verbosity settings. please just do a quick replacement to xf86Msg(X_ERROR, "blahblah"). Other than that, the patch is fine. - The second one (bamboo support) looks good to me though I wish that over time model checking will be somewhat streamlined and won't rely on string checking, temporary variables, etc. There's some possible cleanup work there. Last thing - please make sure you sign off the patches when committing. If you can send me a pull request for the two fixed up patches, I'll merge them in. Thanks again for your work! Cheers, Peter ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
