On Thu, Dec 10, 2009 at 02:37:55AM +0100, Enrico Ros wrote: > On Thursday 10 December 2009 01:13:05 you wrote: > > Hi Enrico, > > > > On Wed, Dec 09, 2009 at 03:05:36PM +0100, Enrico Ros wrote: > > > Hello, I just opened a git clone of xf86-input-wacom on Gitorious at: > > > http://gitorious.org/linuxwacom/xf86-input-wacom > > > ... > > > > Thanks for the patches and you're right, pull is the easiest way. > > > > Two comments regarding the patches though: > > - using ErrorF is generally discouraged in the driver. While it's a public > > symbol exported by the server, it sidesteps some grep-able prefixes and > > the verbosity settings. please just do a quick replacement to > > xf86Msg(X_ERROR, "blahblah"). Other than that, the patch is fine. > > > > - The second one (bamboo support) looks good to me though I wish that over > > time model checking will be somewhat streamlined and won't rely on string > > checking, temporary variables, etc. There's some possible cleanup work > > there. > > > > Last thing - please make sure you sign off the patches when committing. > > If you can send me a pull request for the two fixed up patches, I'll merge > > them in. Thanks again for your work! > > Thanks for the tips, I need them, I'm new to x development. I've corrected > the > 2 patches and forced the update to the "for-whot" branch (this time only), > just to keep things as clean as possible.
if you're keeping a "for-whot" branch, feel free to force a rebase if I don't pull from you with comments on the patches. since this branch only exists as a target to merge into master, it's best to keep it as clean as possible so IMO you did the right thing here. merged and pushed, thanks. Cheers, Peter ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
