On Thursday 10 December 2009 01:13:05 you wrote: > Hi Enrico, > > On Wed, Dec 09, 2009 at 03:05:36PM +0100, Enrico Ros wrote: > > Hello, I just opened a git clone of xf86-input-wacom on Gitorious at: > > http://gitorious.org/linuxwacom/xf86-input-wacom > > ... > > Thanks for the patches and you're right, pull is the easiest way. > > Two comments regarding the patches though: > - using ErrorF is generally discouraged in the driver. While it's a public > symbol exported by the server, it sidesteps some grep-able prefixes and > the verbosity settings. please just do a quick replacement to > xf86Msg(X_ERROR, "blahblah"). Other than that, the patch is fine. > > - The second one (bamboo support) looks good to me though I wish that over > time model checking will be somewhat streamlined and won't rely on string > checking, temporary variables, etc. There's some possible cleanup work > there. > > Last thing - please make sure you sign off the patches when committing. > If you can send me a pull request for the two fixed up patches, I'll merge > them in. Thanks again for your work!
Thanks for the tips, I need them, I'm new to x development. I've corrected the 2 patches and forced the update to the "for-whot" branch (this time only), just to keep things as clean as possible. The branch is ready for merge. Enrico -- Caselle da 1GB, trasmetti allegati fino a 3GB e in piu' IMAP, POP3 e SMTP autenticato? GRATIS solo con Email.it http://www.email.it/f Sponsor: Apri Conto Arancio, se lo attivi entro il 31/12/2009, ricevi 100 Euro da spendere presso Media World. Aprilo adesso * * Clicca qui: http://adv.email.it/cgi-bin/foclick.cgi?mid=9985&d=10-12 ------------------------------------------------------------------------------ Return on Information: Google Enterprise Search pays you back Get the facts. http://p.sf.net/sfu/google-dev2dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
