Chris, response inline

On Mon, 2010-01-18 at 21:22 -0600, Chris Bagwell wrote:
> Jason, I've been holding off until your latest patches before I looked
> in depth into xf86-input-wacom to get rid of the unwanted button press
> for touch pad.  Now that I'm digging into your patches (specifically,
> 0004), I see there is feature mismatch in WcmEvent() between the two X
> input drivers.  I'll need to study that more and see about aligning
> and/or porting your patches.
> 
> I do have one initial question.  Are you using Capacity=3 as a method
> to disable the unwanted button click from wcmUSB.c still?  Or in other
> words, are there any values one could set Capacity to via xsetwacom
> and then see that button click come back?
Yes and no. I tried it last night and if you change the Capacity value
with xsetwacom, it takes more pressure on the pad to actuate a single
finger click or a two finger right click.  There is some scaling
somewhere (can't quite remember where I saw it) that uses the pressure
and current capacity value to determine the threshold for click.

> I've not tested it but Ping leads me to believe that Bamboo P&T is not
> accurate enough such that the Capacity threshold logic would work.

Like I said, it seems to work well enough for me. It's actually nice to
be able to adjust it based on how you normally tap the pad.

> 
> Assuming Bamboo P&T can not correctly support Capacity threshold
> feature, I'm wondering if following in wcmUSB.c:
> 
>                                 if (common->wcmCapacityDefault < 0)
>                                         MOD_BUTTONS (0, event->value);
> 
> wouldn't be better some version of:
> 
>                                 if (common->wcmCapacityDefault < 0
> && !(a bamboo P&T))
>                                         MOD_BUTTONS (0, event->value);
> 
> and then remove your related parts of your patches that are setting
> Capacity to 3. 

I wouldn't since capacity seems to work.

> 
> I can only provide at most comments on patches 0001, 0002, and 0005
> until I understand the differences between the two X drivers... so I'm
> off to do that first.
> 

I tried to keep the patches separate so that you and Peter could
evaluate the separately.  Just keep in mind that some of them may remove
what others do earlier in the sequence.

Jason


------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel

Reply via email to