Hi Jason,
I didn't get a chance to go through the patches today and I don't feel I
have time to do so in the coming days. So, I am "giving up". Well, I mean
we will rely on you to work on the linuxwacom patches and Chris on
xf86-input-wacom patches, respectively. I will address your original email
in a separate reply soon.
Hi Chris,
Since I don't have time to work on the driver myself, I don't feel it is
fair for me to make specific suggestions any more. I withdraw the
suggestions I've made to Bamboo P&T so far. You are free to do whatever it
makes sense to Bamboo P&T :).
A few "common sense" that I'd like to share with you so you know what basic
quality of the driver that we'd like to preserve:
1. The new patches would not break the existing support. Using separate
routines would make this maintenance effort easier.
2. Gather a broader testing feedback. In addition to the testing that Peter
and I would make before merging the patches, it would be greatly appreciated
if you can lead some testing effort on the X server versions that are
appropriate to the patches that you are working on.
3. xf86-input-wacom isn't in-sync with linuxwacom (they might would never
be due to the lack of resources and the differences in their purpose and
design). So, when you work on the two drivers, please split the patches
clearly so we know which ones are for Bamboo P&T support and which ones are
to bring the two drivers closer.
I am very grateful for your effort and I am truly sorry for any misleading
suggestion that I've made.
Ping
On Mon, Jan 18, 2010 at 7:22 PM, Chris Bagwell <ch...@cnpbagwell.com> wrote:
>
>
> On Mon, Jan 18, 2010 at 10:48 AM, Jason Childs <
> obliv...@users.sourceforge.net> wrote:
>
>> Hi Ping,
>>
>> I'm attaching a tar.bz2 of 17 patches that capture the changes I've done
>> over the last three days.
>>
>> At this point the patch gets the Bamboo P&T touch working with capacity,
>> relative mode, single click, and two finger gestures. Unfortunately the
>> pad buttons had to go. They are sharing the same channel as the second
>> finger and mess up the proximity reading for it. Other than that, I
>> think everything has been incorporated, including changes to
>> wacomcpl-exec.
>>
>>
> Jason, I've been holding off until your latest patches before I looked in
> depth into xf86-input-wacom to get rid of the unwanted button press for
> touch pad. Now that I'm digging into your patches (specifically, 0004), I
> see there is feature mismatch in WcmEvent() between the two X input
> drivers. I'll need to study that more and see about aligning and/or porting
> your patches.
>
> I do have one initial question. Are you using Capacity=3 as a method to
> disable the unwanted button click from wcmUSB.c still? Or in other words,
> are there any values one could set Capacity to via xsetwacom and then see
> that button click come back? I've not tested it but Ping leads me to
> believe that Bamboo P&T is not accurate enough such that the Capacity
> threshold logic would work.
>
> Assuming Bamboo P&T can not correctly support Capacity threshold feature,
> I'm wondering if following in wcmUSB.c:
>
> if (common->wcmCapacityDefault < 0)
> MOD_BUTTONS (0, event->value);
>
> wouldn't be better some version of:
>
> if (common->wcmCapacityDefault < 0 && !(a
> bamboo P&T))
> MOD_BUTTONS (0, event->value);
>
> and then remove your related parts of your patches that are setting
> Capacity to 3.
>
> I can only provide at most comments on patches 0001, 0002, and 0005 until I
> understand the differences between the two X drivers... so I'm off to do
> that first.
>
> Chris
>
>
------------------------------------------------------------------------------
Throughout its 18-year history, RSA Conference consistently attracts the
world's best and brightest in the field, creating opportunities for Conference
attendees to learn about information security's most important issues through
interactions with peers, luminaries and emerging and established companies.
http://p.sf.net/sfu/rsaconf-dev2dev
_______________________________________________
Linuxwacom-devel mailing list
Linuxwacom-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
