On Wed, Feb 24, 2010 at 10:55:29AM -0600, Chris Bagwell wrote: > While trying to understand MaxX usage, I notice similar strange code > in wcmRotateTablet() that I'm guessing was added at same time since > its called during updates to prop_rotate.
Yes, there are more bits like this where it doesn't really make sense, they just need time tracking down :) for the record - the only point in replacing options from within the driver is - the driver later accesses this option, it saves us from keeping a tmp variable. one usecase for this is auto-dev, where we can replace the device-option if needed (I don't think we do, but it's a possible usecase:) - options that need to be duplicated into the dependent devices (hotplugged ones). other than that, there isn't really a reason to change the options at runtime. especially since it might be confusing in the logs; the server always prints out options used by the driver so if a Option "Foobar" "yes" pops up in the logs when the actual config is set to "no", then that needs at least explaining in the driver log. Cheers, Peter > On Tue, Feb 23, 2010 at 11:07 PM, Peter Hutterer > <[email protected]> wrote: > > I don't quite know why this is there but it strikes me as really really > > weird and the commit message for this code gives no indication on why it's > > necessary. > > > > Signed-off-by: Peter Hutterer <[email protected]> > > --- > > src/wcmXCommand.c | 2 -- > > 1 files changed, 0 insertions(+), 2 deletions(-) > > > > diff --git a/src/wcmXCommand.c b/src/wcmXCommand.c > > index 79ca83a..a4edb41 100644 > > --- a/src/wcmXCommand.c > > +++ b/src/wcmXCommand.c > > @@ -69,14 +69,12 @@ int wcmDevSwitchModeCall(LocalDevicePtr local, int mode) > > if ((mode == Absolute) && !is_absolute) > > { > > priv->flags |= ABSOLUTE_FLAG; > > - xf86ReplaceStrOption(local->options, "Mode", "Absolute"); > > wcmInitialCoordinates(local, 0); > > wcmInitialCoordinates(local, 1); > > } > > else if ((mode == Relative) && is_absolute) > > { > > priv->flags &= ~ABSOLUTE_FLAG; > > - xf86ReplaceStrOption(local->options, "Mode", "Relative"); > > wcmInitialCoordinates(local, 0); > > wcmInitialCoordinates(local, 1); > > } > > -- > > 1.6.6.1 ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
