On Sat, Feb 27, 2010 at 05:17:07PM -0800, Ping Cheng wrote: > As far as I can tell: there were two reasons to make the > xf86ReplaceStrOption() call when an option is changed: > > Recording the change in the log file (thus the confusing part :) so we > (or someone) can trace the change in the log; > > Synchronizing the option stored locally, which was just changed, with > the one in the server (if there is one) in case a xf86CheckStrOption() > is called somewhere (don't ask me where since I don't know if anywhere > else would call it). If we don't call xf86ReplaceStrOption(), > xf86CheckStrOption would return the initial option (or no option at > all even if the driver has one now). > > Do we really need to do this?
No-one except the driver needs to access the options and we shouldn't do so anywhere but the init sequence. With the internal hotplugging scheme the wacom driver is special, so there is a valid reason to rewrite options for the dependent devices but that doesn't affect run-time configuration changes. So I think we can purge most (if not all) of these. Cheers, Peter ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
