On Wed, Feb 24, 2010 at 10:44:59AM -0600, Chris Bagwell wrote: > I really like this patch to clean up output of xinput list-props and > the other similar patch. This is a good patch that I'd commit as-is. > > I do notice now additional issues related to pressure curve setting > that would be nice to fix. I can help if we all agree on below > updates. > > * Below, the origin code is hardcoding default values to 0, 0, 100, > 100. It should be defaulting to values stored in priv->nPressCtrl[] > to be safe (which is 0, 0, 100, 100 right now). > > * Logic validating values are between 0 and 100 is duplicated in > wcmXCommand.c, wcmValidateDevice.c, and wcmFilter.c. It would be nice > to give wcmSetPressureCurve a return value and centralize error > checking there. > > * Logic in wcmValidateDevice.c checks for (!IsCurser(priv) && > !(IsTouch(priv)). Your check for (IsSytlus(priv) && IsEraser(priv)) > is easier to understand the intent. It would be nice to align both > places. > > * It would be nice to add a note to man pages that PressCurve applies > only to stylus and eraser.
good points, thank you. I've coded them up, they will be included in the next patch spam bomb that'll go out in a minute. Cheers, Peter ------------------------------------------------------------------------------ Download Intel® Parallel Studio Eval Try the new software tools for yourself. Speed compiling, find bugs proactively, and fine-tune applications for parallel performance. See why Intel Parallel Studio got high marks during beta. http://p.sf.net/sfu/intel-sw-dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
