Dnia 29 Marca 2012, 8:22 am, Cz, Nikolai Kondrashov napisał(a): > Hi Chris, > > On 03/23/2012 07:20 PM, Nikolai Kondrashov wrote: >> On 03/23/2012 07:00 PM, Chris Bagwell wrote: >>> On Thu, Mar 22, 2012 at 2:37 PM, Nikolai Kondrashov<spbn...@gmail.com> >>> wrote: >>>> + /* Center the reported range on zero */ >>>> + /* FIXME remove once kernel is fixed */ >>>> + common->wcmTiltXOff = - (absinfo.minimum + absinfo.maximum) / 2; >>> >>> Why is this a FIXME? It seems reasonable to center to zero here. For >>> example, there is no intention to "fix" Wacom kernel drivers, are >>> there? >> >> Well, I intended to "fix" them, actually. The thing is, the existing >> range >> wacom drivers use is not straightforward and contradicts HID >> specification. >> >> I was hoping to make a patch for the kernel drivers, so, after a while >> (at >> your discretion), this centering could be dropped. > > Do you still object to the FIXME and fixing the kernel driver? >
My thoughts on that "issue": if the device is reporting values in range 0-127 the kernel driver shouldn't try to "improve" them just because it's more convinient for the userspace. Changing 0-127 range to -63 to 64 shouldn't happen in the kernel driver. I'd suggest to ask on linux-input if the mainaner will be happy to accept a patch that converts 0-127 range to -63 to 64, before you include a comment like "once the kernel is fixed" as it might never happen. -- Regards, Przemo Firszt ------------------------------------------------------------------------------ Better than sec? Nothing is better than sec when it comes to monitoring Big Data applications. Try Boundary one-second resolution app monitoring today. Free. http://p.sf.net/sfu/Boundary-dev2dev _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
