Hey Bastien, Bastien Nocera said the following on 01/29/2013 09:56 AM: > On Tue, 2013-01-29 at 09:47 +0100, Olivier Fourdan wrote: > <snip> >> Does the attached patch works for you? To test, make sure you remove >> your added definition first... > The library should complain loudly if there are double definitions.
Are you sure? I thought the library would support multiple matches. That was added with commit ff93e2e2 [1]. libwacom_parse_tablet_keyfile() will parse DeviceMatch [2] and call libwacom_matchstr_to_matches() [3] to add multiple matches. libwacom_update_match() [4] will check that the bus+vendor+product are not in double, but thatwould not be the case here since the USB Id differs. So I see no reason for the library to complain loudly. And fact is it passes "make check" just fine with this (I did try before posting my reply, though). If all this is not supposed to be supported then we may well have a bug indeed. Cheers, Olivier -- [1] http://linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/libwacom;a=commit;h=ff93e2e2 [2] linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/libwacom;a=blob;f=libwacom/libwacom-database.c;hb=HEAD#l354 [3] linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/libwacom;a=blob;f=libwacom/libwacom-database.c;hb=HEAD#l132 [4] http://linuxwacom.git.sourceforge.net/git/gitweb.cgi?p=linuxwacom/libwacom;a=blob;f=libwacom/libwacom.c;hb=HEAD#l764 ------------------------------------------------------------------------------ Master Visual Studio, SharePoint, SQL, ASP.NET, C# 2012, HTML5, CSS, MVC, Windows 8 Apps, JavaScript and much more. Keep your skills current with LearnDevNow - 3,200 step-by-step video tutorials by Microsoft MVPs and experts. ON SALE this month only -- learn more at: http://p.sf.net/sfu/learnnow-d2d _______________________________________________ Linuxwacom-devel mailing list Linuxwacom-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linuxwacom-devel
