It's a good question - here's a two part answer: 1. The actual printing of the output is the longest blocking in many cases (as mentioned in the description: the actual data gathering for "target module dump symtab" can take 1-2sec, but printing it can take 20min. For quick experiment, try dis -p -c 10000). 2. This change provides the scaffolding for cooperative interruption that can be used were appropriate, not just the printing part. I did this for "target" commands (see the changes in CommandObjectTarget.cpp), and it's very easy to do the same in other places as needed.
On Mon, Sep 18, 2017 at 3:05 PM, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > I think Zach might be correct. If we already gathered the data, why not > just output it all? Lets answer this first before returning to which > implementation to use when parsing it up into lines and dumping it. Seems a > shame to throw any data away. > > > https://reviews.llvm.org/D37923 > > > >
_______________________________________________ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
