labath added a comment.
Thank you. I like the tests a lot. I think I'll steal the implementation of
this when I get around to parsing breakpad unwind instructions. ;)
This looks fine to me, but one of the windows folks should take a look at it
too.
================
Comment at:
source/Plugins/SymbolFile/PDB/PDBFPOProgramToDWARFExpression.cpp:336-337
+ break;
+ default:
+ llvm_unreachable("Invalid binary operation");
+ }
----------------
These default labels go against llvm style guide
<http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations>.
================
Comment at:
source/Plugins/SymbolFile/PDB/PDBFPOProgramToDWARFExpression.cpp:483-487
+ if (lvalue_name == register_name) {
+ // found target assignment program - no need to parse further
+ result = rvalue_ast;
+ break;
+ }
----------------
Is this true? Is it not possible for a program to depend on a value of a
register which will be defined later?
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55122/new/
https://reviews.llvm.org/D55122
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
