jankratochvil added inline comments.
================
Comment at: lldb/include/lldb/Core/SearchFilter.h:102
+ ///
+ /// \note if not overriden, default implementation always \c true.
virtual bool ModulePasses(const FileSpec &spec);
----------------
I am not against it but FYI in a paragraph above there is already written: `The
default implementation is "Everything Passes."`
English: IMO missing "returns".
================
Comment at: lldb/source/Core/SearchFilter.cpp:416
-bool SearchFilterByModule::AddressPasses(Address &address) {
- // FIXME: Not yet implemented
- return true;
----------------
This comment will get lost. Maybe you could keep this override just due to the
FIXME comment. Or keep the FIXME comment some other way there. Or file a
Bugzilla tracking Bug instead.
It is there since: [[
https://github.com/llvm/llvm-project/commit/30fdc8d841c9d24ac5f3d452b6ece84ee0ac991c
| Initial checkin of lldb code from internal Apple repo. ]]
================
Comment at: lldb/source/Core/SearchFilter.cpp:542
-bool SearchFilterByModuleList::AddressPasses(Address &address) {
- // FIXME: Not yet implemented
- return true;
----------------
Likewise.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77376/new/
https://reviews.llvm.org/D77376
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
