kwk added a subscriber: lattner.
kwk added a comment.
Had some problem with my `arc diff` reporting that another git was running
which it wasn't so I had to update the diff by hand with a bit of trouble.
================
Comment at: lldb/include/lldb/Core/SearchFilter.h:102
+ ///
+ /// \note if not overriden, default implementation always \c true.
virtual bool ModulePasses(const FileSpec &spec);
----------------
jankratochvil wrote:
> I am not against it but FYI in a paragraph above there is already written:
> `The default implementation is "Everything Passes."`
> English: IMO missing "returns".
Thank you for the missing "returns". I'd like to keep the comment.
================
Comment at: lldb/source/Core/SearchFilter.cpp:416
-bool SearchFilterByModule::AddressPasses(Address &address) {
- // FIXME: Not yet implemented
- return true;
----------------
jankratochvil wrote:
> This comment will get lost. Maybe you could keep this override just due to
> the FIXME comment. Or keep the FIXME comment some other way there. Or file a
> Bugzilla tracking Bug instead.
> It is there since: [[
> https://github.com/llvm/llvm-project/commit/30fdc8d841c9d24ac5f3d452b6ece84ee0ac991c
> | Initial checkin of lldb code from internal Apple repo. ]]
I've checked the code myself to find out where it was coming from and found out
that the FIXME is there for almost 10 years. I wonder if @lattner still
remembers why it was there or if it can be removed. By the nature of the other
default implementations below, I wonder if this was accidentally a left-over or
should be put into `SearchFilterByModule::CompUnitPasses` as well?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77376/new/
https://reviews.llvm.org/D77376
_______________________________________________
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
